Tests: Fix flakey ECDSA testing #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
approved these changes
May 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6005 +/- ##
==========================================
+ Coverage 55.86% 55.87% +0.01%
==========================================
Files 481 481
Lines 68357 68357
==========================================
+ Hits 38185 38193 +8
+ Misses 27568 27563 -5
+ Partials 2604 2601 -3 ☔ View full report in Codecov by Sentry. |
jannotti
approved these changes
May 30, 2024
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix flakey ECDSA testing, where a signature component had a leading zero byte, so
big.Int.Bytes()produced a 31 byte slice.The failing job: https://app.circleci.com/pipelines/github/algorand/go-algorand/18380/workflows/1d84e0b5-2ad9-4ac7-94cf-5c6315ac7138/jobs/272246
Test Plan
Test only fix